OpenAustralia.org

The CSV file available at http://www.openaustralia.org/senators/?f=csv contains incorrect URLs for the senators

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: Hackfest Sydney 2009
  • Component/s: Application
  • Labels:
    None

Description

The URLs listed in the CSV file at http://www.openaustralia.org/senators/?f=csv are incomplete. For example, the correct URL for Eric Abetz is http://www.openaustralia.org/senator/eric_abetz/tasmania. The CSV file lists http://www.openaustralia.org/senator/eric_abetz.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ray Haleblian added a comment -

Hmm, which of these URLs wants to be the correct one?

Show
Ray Haleblian added a comment - Hmm, which of these URLs wants to be the correct one?
Hide
Permalink
Ray Haleblian added a comment -

Matthew and I discussed – we want to have the short form URL in the CSV be valid.

Show
Ray Haleblian added a comment - Matthew and I discussed – we want to have the short form URL in the CSV be valid.
Hide
Permalink
Ray Haleblian added a comment -

Feels to me that the URL rewriting rules are treating senators (which get mapped into the mps space) a bit differently than the nominal mps.

Show
Ray Haleblian added a comment - Feels to me that the URL rewriting rules are treating senators (which get mapped into the mps space) a bit differently than the nominal mps.
Hide
Permalink
Ray Haleblian added a comment -

if (is_array($person_id)) {
if ($this_page == 'peer') { # Hohoho, how long will I get away with this for? # Not very long, it made Lord Patel go wrong $person_id = $person_id[0]; } else { $this->valid = false; $this->person_id = $person_id; return; }
}

Show
Ray Haleblian added a comment - if (is_array($person_id)) { if ($this_page == 'peer') { # Hohoho, how long will I get away with this for? # Not very long, it made Lord Patel go wrong $person_id = $person_id[0]; } else { $this->valid = false; $this->person_id = $person_id; return; } }
Hide
Permalink
Ray Haleblian added a comment -

mp PHP changed to make the short form URL already in the CSV valid.

Show
Ray Haleblian added a comment - mp PHP changed to make the short form URL already in the CSV valid.
Hide
Permalink
Henare Degan added a comment -

Hi Ray,

Did this fix get commited? If so, can you please provide a link to the commit?

If the fix is in github but hasn't been deployed, can you please add a note here and assign it to Matthew also?

Show
Henare Degan added a comment - Hi Ray, Did this fix get commited? If so, can you please provide a link to the commit? If the fix is in github but hasn't been deployed, can you please add a note here and assign it to Matthew also?
Hide
Permalink
Ray Haleblian added a comment -

http://github.com/rhaleblian/twfy/commit/d228dc37ccf265c2d0f8b3a03d5b1de76d1421fe

Note that the comment is mislabeled.

Show
Ray Haleblian added a comment - http://github.com/rhaleblian/twfy/commit/d228dc37ccf265c2d0f8b3a03d5b1de76d1421fe Note that the comment is mislabeled.
Hide
Permalink
Ray Haleblian added a comment -

Methinks the commit in the comments needs a pull-pull.

Show
Ray Haleblian added a comment - Methinks the commit in the comments needs a pull-pull.
Hide
Permalink
Matthew Landauer added a comment -

@ray - I'll do it tomorrow. I promise! It's on my todo list.

Show
Matthew Landauer added a comment - @ray - I'll do it tomorrow. I promise! It's on my todo list.
Hide
Permalink
Henare Degan added a comment -

Thanks Ray and Matthew.

Matthew, please close this issue when you've had a chance to deploy (preaching to the choir no doubt

Cheers, Henare

Show
Henare Degan added a comment - Thanks Ray and Matthew. Matthew, please close this issue when you've had a chance to deploy (preaching to the choir no doubt Cheers, Henare
Hide
Permalink
Matthew Landauer added a comment -

@Ray - the commit http://github.com/rhaleblian/twfy/commit/d228dc37ccf265c2d0f8b3a03d5b1de76d1421fe isn't working for me. The behavior of senator links without electoral divisions is unchanged. Am I missing something?

Show
Matthew Landauer added a comment - @Ray - the commit http://github.com/rhaleblian/twfy/commit/d228dc37ccf265c2d0f8b3a03d5b1de76d1421fe isn't working for me. The behavior of senator links without electoral divisions is unchanged. Am I missing something?
Hide
Permalink
Matthew Landauer added a comment -

All good. Merged in the change and deployed. Also applied a couple of small related fixes. Partial senator URLs (missing the state) or now redirected to the canonical URL. Also, the csv file for Senators now includes the full URL

Show
Matthew Landauer added a comment - All good. Merged in the change and deployed. Also applied a couple of small related fixes. Partial senator URLs (missing the state) or now redirected to the canonical URL. Also, the csv file for Senators now includes the full URL

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for OpenAustralia Foundation. Try JIRA - bug tracking software for your team.