OpenAustralia.org

Page for changing your representative is not enabled for mobile

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Mobile
  • Labels:
    None

Description

Follow this link: http://test.openaustralia.org/user/changepc/

On my iphone it shows this in a non-mobile enabled way.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Henare Degan added a comment -

Marking this bug as minor as you can't get to this page from the mobile 'portal'

Show
Henare Degan added a comment - Marking this bug as minor as you can't get to this page from the mobile 'portal'
Hide
Permalink
Matthew Landauer added a comment -

I'm pretty sure you can reach that page on the mobile version. Otherwise I'm fairly sure I wouldn't have submitted the bug.

Show
Matthew Landauer added a comment - I'm pretty sure you can reach that page on the mobile version. Otherwise I'm fairly sure I wouldn't have submitted the bug.
Hide
Permalink
Matthew Landauer added a comment -

To clarify my earlier comment, it doesn't show the page http://test.openaustralia.org/user/changepc optimised for mobile phones

Show
Matthew Landauer added a comment - To clarify my earlier comment, it doesn't show the page http://test.openaustralia.org/user/changepc optimised for mobile phones
Hide
Permalink
Rob Manson added a comment -

Fixed - added error_message_mobile function to easyparliament/page.php.

Show
Rob Manson added a comment - Fixed - added error_message_mobile function to easyparliament/page.php.
Hide
Permalink
Matthew Landauer added a comment -

Latest version deployed to test.openaustralia.org for testing

Show
Matthew Landauer added a comment - Latest version deployed to test.openaustralia.org for testing
Hide
Permalink
Matthew Landauer added a comment -

I just tested this out and it appears not to be fixed. What exactly did you fix to do with error messages?

Show
Matthew Landauer added a comment - I just tested this out and it appears not to be fixed. What exactly did you fix to do with error messages?
Hide
Permalink
Rob Manson added a comment -

Erm...that would be that descriptive string above that describes stuff:

Rob Manson added a comment - 28/Sep/09 01:36 PM
Fixed - added error_message_mobile function to easyparliament/page.php.

Show
Rob Manson added a comment - Erm...that would be that descriptive string above that describes stuff: Rob Manson added a comment - 28/Sep/09 01:36 PM Fixed - added error_message_mobile function to easyparliament/page.php.
Hide
Permalink
Matthew Landauer added a comment -

Hehe. I guess I don't understand what error_message_mobile has to do with this ticket.

Show
Matthew Landauer added a comment - Hehe. I guess I don't understand what error_message_mobile has to do with this ticket.
Hide
Permalink
Rob Manson added a comment -

8) Perhaps it's me that doesn't understand...happy to be pointed at the right code.

When I tested stuff...basically the only way I could get to that page was if an error was thrown (e.g. invalid postcode). All of these displays seemed to be handled by the error_message function in easyparliament/page.php - so as per all the other hacks - ahem I mean elegant workarounds - I created a error_message_mobile function as an alternative.

If you can show me the code pathway that's giving you the page you're talking about then I can try to isolate that and fix that. However this won't be for at least a week...and I would also strongly debate that this is not a blocker. Worst case, for one corner case, you're just going to see the exact same page you currently would today. So you're not losing functionality and it shouldn't stop people seeing the 99.95% of pages that do work fine 8P

Show
Rob Manson added a comment - 8) Perhaps it's me that doesn't understand...happy to be pointed at the right code. When I tested stuff...basically the only way I could get to that page was if an error was thrown (e.g. invalid postcode). All of these displays seemed to be handled by the error_message function in easyparliament/page.php - so as per all the other hacks - ahem I mean elegant workarounds - I created a error_message_mobile function as an alternative. If you can show me the code pathway that's giving you the page you're talking about then I can try to isolate that and fix that. However this won't be for at least a week...and I would also strongly debate that this is not a blocker. Worst case, for one corner case, you're just going to see the exact same page you currently would today. So you're not losing functionality and it shouldn't stop people seeing the 99.95% of pages that do work fine 8P
Hide
Permalink
Matthew Landauer added a comment -

I agree. This definitely isn't a blocker and certainly won't hold up deploying it to production!

To easily get to the problem page.

1. Go to the home page: http://test.openaustralia.org
2. Enter a postcode
3. Return to the homepage
4. Where the "enter your postcode" was before it should say something like "Find out about blah, blah your representative".
5. Next to this it should say "Change". Click on this

Show
Matthew Landauer added a comment - I agree. This definitely isn't a blocker and certainly won't hold up deploying it to production! To easily get to the problem page. 1. Go to the home page: http://test.openaustralia.org 2. Enter a postcode 3. Return to the homepage 4. Where the "enter your postcode" was before it should say something like "Find out about blah, blah your representative". 5. Next to this it should say "Change". Click on this

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for OpenAustralia Foundation. Try JIRA - bug tracking software for your team.