OpenAustralia.org

Cool, add link where?

I guess the best place would be on the current representative's page, so for the example above it would be Kate Ellis:

http://www.openaustralia.org/mp/kate_ellis/adelaide

Core laid down. Need translation table from constituency to four-letter URL. Will write this.

Pull request sent.

Hey Ray,

Looked at my fork queue and your repo and can't see the change, can you please post a link to the commit?

Cheers,

Henare

Edit: Typo

Hi Henare, I hope i didn't goof up on the git side. Can you work with a commit hash from 'git log'?

836b8301e70f0734d34760251393f3df26c934e3

For twfy, the hash is
f5727168dfa4e3d2bf5260f60f8745b42e991fbb

I can't see either of these commits on githubs pages though. But,

bast:twfy rhaleblian$ git status

1. On branch master
2. Your branch is ahead of 'origin/master' by 8 commits.
   #
   nothing to commit (working directory clean)

Ok. You should see the parser commit.

http://github.com/rhaleblian/openaustralia-parser/commit/57ffc79dd728a81efc507591df78c1fd16dfb70c

The web application commit is pending.

http://github.com/rhaleblian/twfy/commit/ee70003d11d4f4866a7473171c65631d0de399be

Hey Ray,

Nice one mate, I can see the changes now. I'll get them deployed to my testing instance in the next couple of days and give you some testing feedback.

Cheers,

Henare

Hi Ray,

I've had a chance to look at your changes to the web application. The only issue I can see is with the syntax of the table creation[0]. I think it should be:

CREATE TABLE election_constituency (code char(4) NOT NULL, name varchar(32) NOT NULL PRIMARY KEY);

rather than:

CREATE TABLE election_constituency (code char(4) NOT NULL, name varchar(32) NOT NULL, PRIMARY KEY name);

But apart from that the changes look great, nice one. I don't know enough about the parser yet to easily review those changes though.

Cheers, Henare

[0] http://github.com/rhaleblian/twfy/commit/ee70003d11d4f4866a7473171c65631d0de399be#diff-0

Your code looks good to me. I'll put that in a future commit.

await testing before closure.

After talking with Matthew, we've moved the election URLs so they use the member_info/member_link code, this is much cleaner. Also, now TWFY does not need to know anything about ABC's website structure.

Hi Ray,

I've tested the latest changes and they look OK from here (maybe change the text "From ABC" to "From the ABC"?).

If the changes are ready to go, mark this issue as resolved and assign it to Matthew for deployment.

@Ray - Have a look in twfy/scripts/mpinfoin.pl - you'll see that this script will load data into the consinfo table from an xml file. So, it would be sweeter if you could generate that XML file in the parser, rather than loading the data yourself directly into the database.

Oops.

All fixed now and deployed. Thanks for the fix Ray!

As John Maynard Keynes was famous for saying, "That's dope."